Always track file-based layers in QFieldCloud #5118
Conversation
If the layer is configured as "NO_ACTION" for QFieldCloud, then this layer is never tracked for changes in QFieldCloud. This means any changes on this layer will never reach QFieldCloud. This development ignores whatever is configured as cloud action. When the layer is file-based and it is not configured as "REMOVE", then the layer will be tracked by QFielCloud.
|
🎉 Ta-daaa, freshly created APKs are available for fba35ba: arm64-android |
Co-authored-by: Matthias Kuhn <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| if ( !layer->dataProvider() ) | ||
| { |
There was a problem hiding this comment.
warning: implicit conversion 'const QgsDataProvider *' -> bool [readability-implicit-bool-conversion]
| { | |
| if ( layer->dataProvider() == nullptr ) |
|
|
||
| QgsProviderMetadata *providerMetadata = QgsProviderRegistry::instance()->providerMetadata( layer->dataProvider()->name() ); | ||
| QVariantMap metadata = providerMetadata->decodeUri( layer->source() ); | ||
|
|
There was a problem hiding this comment.
warning: variable 'metadata' of type 'QVariantMap' (aka 'QMap<QString, QVariant>') can be declared 'const' [misc-const-correctness]
| QVariantMap const metadata = providerMetadata->decodeUri( layer->source() ); |
| if ( resolvedFilename.startsWith( QStringLiteral( "localized:" ) ) ) | ||
| { | ||
| return QFile::exists( resolvedFilename.mid( 10 ) ); | ||
| } |
There was a problem hiding this comment.
warning: 10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers]
return QFile::exists( resolvedFilename.mid( 10 ) );
^| /** | ||
| * Returns if the \a layer is a file-based or a remote layer. | ||
| * | ||
| * @param layer to be checked |
There was a problem hiding this comment.
warning: member variable 'username' has public visibility [misc-non-private-member-variables-in-classes]
QString username;
^| * Returns if the \a layer is a file-based or a remote layer. | ||
| * | ||
| * @param layer to be checked | ||
| * @return const bool true if the layer is file-based |
There was a problem hiding this comment.
warning: member variable 'email' has public visibility [misc-non-private-member-variables-in-classes]
QString email;
^
|
@suricactus , is this still relevant? |
If the layer is configured as "NO_ACTION" for QFieldCloud, then this layer is never tracked for changes in QFieldCloud. This means any changes on this layer will never reach QFieldCloud.
This development ignores whatever is configured as cloud action. When the layer is file-based and it is not configured as "REMOVE", then the layer will be tracked by QFielCloud.